Skip to content

Add post log parser to look for repeated test runs and annotate as in… #8696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jmaher
Copy link
Collaborator

@jmaher jmaher commented May 13, 2025

…termittent.

@jmaher
Copy link
Collaborator Author

jmaher commented May 13, 2025

this is a WIP with an intentional failure where I would add unittests. I don't want to spend the time adding tests until I know this is something we want.

@jmaher jmaher self-assigned this May 14, 2025
@jmaher jmaher marked this pull request as draft May 14, 2025 12:49
@jmaher jmaher force-pushed the cfparser branch 5 times, most recently from 9f30375 to 52cf693 Compare June 9, 2025 20:30
@jmaher
Copy link
Collaborator Author

jmaher commented Jun 9, 2025

I have tests (I feel they are hacky), and need to review my code to make it more presentable.

There are a couple missing things:

before landing/review:

  • only run on staging

before production (ideally):

  • determine if classification_id = 4 is desired or another id (even a new one)
  • see if there is a creative way to deal with "infra" failures- I have some comments indicating desired state

@jmaher jmaher force-pushed the cfparser branch 2 times, most recently from adf43e6 to cba55ab Compare June 10, 2025 16:30
@jmaher
Copy link
Collaborator Author

jmaher commented Jun 10, 2025

latest code is ready for review and will run everywhere except production.

@jmaher jmaher requested a review from Archaeopteryx June 10, 2025 16:55
@jmaher jmaher marked this pull request as ready for review June 11, 2025 21:04
@jmaher jmaher force-pushed the cfparser branch 2 times, most recently from 9566319 to 0554316 Compare June 14, 2025 22:54
@jmaher
Copy link
Collaborator Author

jmaher commented Jun 15, 2025

@Archaeopteryx I have added another commit to include the new failure classification id, sort of using https://github.com/mozilla/treeherder/blame/3f44c1dbf610206b123c2c3c466e2be5d8da6176/treeherder/model/fixtures/failure_classification.json#L38 as a template.

@jmaher jmaher force-pushed the cfparser branch 2 times, most recently from 5e60933 to 6b89494 Compare June 27, 2025 14:52
Copy link
Collaborator

@Archaeopteryx Archaeopteryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to "Request changes" for the comments added today.

@jmaher jmaher force-pushed the cfparser branch 2 times, most recently from 396e017 to a97d9b0 Compare July 1, 2025 21:04
@jmaher
Copy link
Collaborator Author

jmaher commented Jul 2, 2025

@Archaeopteryx I have updated this to address your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants